Re: [PATCH] [Microblaze]: PIC Data Text Relative

Michael Eager Mon, 19 Mar 2018 13:08:04 -0700

Hi Andrew --

Good work.


Please submit your updated patch.  Check that you follow
GNU coding standards.  Also make sure that the new options
are documented in gcc/doc/invoke.texi.

On 03/18/18 03:27, Andrew Sadek wrote:

Hello Michael,

I have run the test using the new PIC options.
Actually, I have discovered 2 unhandled cases in'microblaze_expand_move' + missing conditions in linker relax
leading some test cases execution to fail.
After fixing them, I made a re-run for the whole regression, and theresults analogy below:
Original, without my patch:
         === gcc Summary ===

# of expected passes        90776
# of unexpected failures    1317
# of unexpected successes    3
# of expected failures        207
# of unresolved testcases    115
# of unsupported tests        2828

With my patch, calling '-fPIE - mpic-data-text-rel'
         === gcc Summary ===

# of expected passes        90843
# of unexpected failures    1256
# of unexpected successes    3
# of expected failures        207
# of unresolved testcases    115
# of unsupported tests        2853
After running the 'dg-cmp-results.sh' in contrib folder, the PASS->FAILare below:
PASS->FAIL: gcc.dg/uninit-19.c (test for excess errors)
PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var1.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var2.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O2 -flto-fno-use-linker-plugin -flto-partition=none scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O2 -flto-fuse-linker-plugin -fno-fat-lto-objects scan-assemblerlwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
the 'gcc.dg/uninit-19.c ' already fails with -fPIE, and for the othersin microblaze,expectation is r0 or r13 as a base register which is not the case here'r20', and these tests also fails with -fPIE.Moreover, the test cases that failed due 'unresolvedGLOBAL_OFFSET_TABLE' now pass as we do not have GOT in data text relative.
Please tell me if any adjustments needed or If I need to re-run nything.

Thanks
On Sun, Mar 18, 2018 at 12:25 PM, Andrew Sadek<andrew.sadek...@gmail.com <mailto:andrew.sadek...@gmail.com>> wrote:
    Hello Michael,

    I have run the test using the new PIC options.
    Actually, I have discovered 2 unhandled cases in
    'microblaze_expand_move' + missing conditions in linker relax
    leading some test cases execution to fail.
    After fixing them, I made a re-run for the whole regression, and the
    results analogy below:

    Original, without my patch:
             === gcc Summary ===

    # of expected passes        90776
    # of unexpected failures    1317
    # of unexpected successes    3
    # of expected failures        207
    # of unresolved testcases    115
    # of unsupported tests        2828

    With my patch, calling '-fPIE - mpic-data-text-rel'
             === gcc Summary ===

    # of expected passes        90843
    # of unexpected failures    1256
    # of unexpected successes    3
    # of expected failures        207
    # of unresolved testcases    115
    # of unsupported tests        2853

    After running the 'dg-cmp-results.sh' in contrib folder, the
    PASS->FAIL are below:

    PASS->FAIL: gcc.dg/uninit-19.c (test for excess errors)
PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
    PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2 -flto
    -fno-use-linker-plugin -flto-partition=none   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
    PASS->FAIL: gcc.target/microblaze/others/data_var1.c   -O2 -flto
    -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var1.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var1.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
    PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2 -flto
    -fno-use-linker-plugin -flto-partition=none   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
    PASS->FAIL: gcc.target/microblaze/others/data_var2.c   -O2 -flto
    -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0
PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var2.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/data_var2.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r0PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2 -flto
    -fno-use-linker-plugin -flto-partition=none   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c   -O2 -flto
    -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var1.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2 -flto
    -fno-use-linker-plugin -flto-partition=none   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c   -O2 -flto
    -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var2.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2 -flto
    -fno-use-linker-plugin -flto-partition=none   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c   -O2 -flto
    -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var4.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2 -flto
    -fno-use-linker-plugin -flto-partition=none   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c   -O2 -flto
    -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -O3 -gscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/sdata_var5.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2
    -flto -fno-use-linker-plugin -flto-partition=none   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O2
    -flto -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c   -O3
    -g   scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst1_gpopt.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O0scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O1scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2
    -flto -fno-use-linker-plugin -flto-partition=none   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O2
    -flto -fuse-linker-plugin -fno-fat-lto-objects   scan-assembler
    lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -O2scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c   -O3
    -g   scan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
PASS->FAIL: gcc.target/microblaze/others/string_cst2_gpopt.c -Osscan-assembler lwi\tr([0-9]|[1-2][0-9]|3[0-1]),r13
    the 'gcc.dg/uninit-19.c ' already fails with -fPIE, and for the
    others in microblaze,
    expectation is r0 or r13 as a base register which is not the case
    here 'r20', and these tests also fails with -fPIE.
    Moreover, the test cases that failed due 'unresolved
    GLOBAL_OFFSET_TABLE' now pass as we do not have GOT in data text
    relative.

    Attached the compare output of the scripit with verbosity 2.
    Please tell me if any adjustments needed or If I need to re-run nything.

    Thanks


    On Tue, Mar 13, 2018 at 10:44 PM, Michael Eager <ea...@eagerm.com
    <mailto:ea...@eagerm.com>> wrote:

        On 03/13/18 00:56, Andrew Sadek wrote:

            Ok, so you mean with '-fPIC -mpic-data-text-relative' as I
            do in my test case ?
            If all is Ok, execution and compilation shall ideally pass
            for the test cases.


        Correct.

        I want to make sure of two things:
           -- Your patch doesn't break anything (i.e., cause a
        regression) when
              you don't use the options.  This seems complete.
           -- Your patch works as intended when you do use the options.

            But I have noticed that there are some output pattern checks
            done in some test cases and this may fail since the output
            assembly is different,
            anyway I shall give it a try and send you the results with
            the new options.


        There should be no target dependencies in the generic GCC tests.
        Different instruction patterns which generate the correct
        results should
        not be a problem.
--Michael Eager ea...@eagerm.com <mailto:ea...@eagerm.com>
        1960 Park Blvd., Palo Alto, CA 94306
--
    Andrew




--

Andrew


--
Michael Eager    ea...@eagerm.com
1960 Park Blvd., Palo Alto, CA 94306

Re: [PATCH] [Microblaze]: PIC Data Text Relative

Reply via email to