On Mar 20, 2018, Jason Merrill <ja...@redhat.com> wrote:

>> +  if (id == error_mark_node)
>> +    return error_mark_node;

> Why wait until here to return?  There are error returns immediately
> above and below your first hunk.

QOI.  Returning immediately, we then get other errors.  We could consume
tokens till the end of the declaration, but I figured we might as well
try to parse them and see whether there were any other legitimate errors
to report.

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist|Red Hat Brasil GNU Toolchain Engineer

Reply via email to