On Mon, Mar 26, 2018 at 10:42 PM, Tsimbalist, Igor V <igor.v.tsimbal...@intel.com> wrote: >> -----Original Message----- >> From: H.J. Lu [mailto:hjl.to...@gmail.com] >> Sent: Monday, March 26, 2018 5:59 PM >> To: Tsimbalist, Igor V <igor.v.tsimbal...@intel.com> >> Cc: gcc-patches@gcc.gnu.org; Uros Bizjak <ubiz...@gmail.com> >> Subject: Re: [PATCH] i386: Insert ENDBR to trampoline for -fcf- >> protection=branch -mibt >> >> On Mon, Mar 26, 2018 at 8:23 AM, Tsimbalist, Igor V >> <igor.v.tsimbal...@intel.com> wrote: >> >> -----Original Message----- >> >> From: Lu, Hongjiu >> >> Sent: Sunday, March 25, 2018 12:50 AM >> >> To: gcc-patches@gcc.gnu.org; Uros Bizjak <ubiz...@gmail.com>; >> Tsimbalist, >> >> Igor V <igor.v.tsimbal...@intel.com> >> >> Subject: [PATCH] i386: Insert ENDBR to trampoline for -fcf- >> >> protection=branch -mibt >> >> >> >> When -fcf-protection=branch -mibt are used, we need to insert ENDBR >> >> to trampoline. TRAMPOLINE_SIZE is creased by 4 bytes to accommodate >> >> 4-byte ENDBR instruction. >> >> >> >> OK for trunk? >> > >> > Regarding the test. Is it possible to check what is generated in a >> trampoline? In particular, that endbr is generated. >> > >> >> I think run-time test is sufficient. > > Ok then.
Rubber-stamp OK. Uros.
