Maciej Rozycki <maciej.rozy...@mips.com> writes: > Given that the SVR4 vs PLT code model consideration is irrelevant for > this test case rather than rewriting the regular expression to match > this variant of code just enforce the PLT model by using the `-mplt' > option. It is safe to use this option unconditionally as it is silently > ignored with configurations that do not support this model, e.g. bare > metal ELF. > > gcc/testsuite/ > * gcc.target/mips/data-sym-pool.c (dg-options): Add `-mplt'. > --- > Hi, > > I have regression-tested this with the `mips-mti-linux-gnu' target and > the o32, n32 and n64 ABIs. The two latters are demoted to o64 by the > test framework due to the lack of MIPS16 support for the hard-float > variants of these ABIs and I don't have soft-float multilibs configured, > so instead I have verified n32/soft-float and n64/soft-float variants by > hand. The latter revealed the need for 2/2. > > Finally I do not have a bare metal ELF configuration available for > regression-testing right now, so I only verified that `-mplt' is > silently ignored. Code generated is expected to be the same as in the > PLT mode. > > OK to apply?
Hi Maciej, Sorry for skimming past this and being slow to respond. I agree with your choice of forcing an option to stabilise the generated code it does tend to future proof better than leaving options floating. OK to apply but given the release date I've added RMs to approve for trunk right now. Thanks, Matthew
