On 05/28/2018 03:11 AM, Richard Biener wrote:
On Fri, May 25, 2018 at 10:15 PM Martin Sebor <mse...@gmail.com> wrote:
Attached is revision 3 of the patch incorporating your
determine_value_range function with the requested changes.
I'm somewhat torn about removing the "basic" interface on SSA names
so can you please not change get_range_info for now and instead
use determine_value_range in get_size_range for now?
I can do that. Can you explain why you're having second thoughts
about going this route?
FWIW: I've already made changes to most clients to get_range_info
to let them call the function for non-SSA arguments and have been
testing the (incremental) patch. I haven't seen a dramatic increase
in the number of successful calls to the function as a result so it
doesn't seem like it would be too much of an improvement. I did
notice that some calls end up returning a one-element range, i.e.,
N, N]. Unless callers are prepared to handle such ranges this could
expose bugs or optimization opportunities. Is it worth finishing
this up?
Martin
