On Fri, 2018-06-08 at 20:41 +0000, Bernd Edlinger wrote: > On 06/08/18 16:28, David Malcolm wrote: > > On Fri, 2018-06-08 at 14:03 +0000, Bernd Edlinger wrote: > > > Hi! > > > > > > > > > This patch converts the splay-tree internals into a template, and > > > makes > > > the typed_splay_tree template really type-safe. Previously > > > everything > > > would break apart if KEY_TYPE or VALUE_TYPE would not be pointer > > > types. > > > This limitation is now removed. > > > > > > I took the freedom to add a remove function which is only for > > > completeness and test coverage, but not (yet) used in a > > > productive > > > way. > > > > > > > > > Bootstrapped and reg-tested on x86_64-linux-gnu. > > > Is it OK for trunk? > > > > Was this testing done with "jit" enabled? (there's some usage of > > typed_splay_tree there, for jit's equivalent of switch statements) > > > > Note that the jit frontend isn't covered by "all" in --enable- > > languages; it has to be added manually, iirc since it requires -- > > enable-host-shared. > > > > Yes, good point. I repeated the test with --enable-host-shared > and all jit tests did pass.
Thanks! Dave
