On 05/30/2018 04:41 AM, Tom de Vries wrote:
> Hi,
>
> this patch tests the error behaviour of dg-final directives when called with
> an
> incorrect number of arguments.
>
> The test is lazy, in that it doesn't bother to pass correct arguments,
> assuming
> that the number of arguments check is done before checking the actual
> arguments.
>
> Using the patch, I managed to find a few things that needed to be fixed:
> - [testsuite] Fix error message in scan-hidden/scan-not-hidden
> https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01599.html
> - [testsuite] Use correct proc names in scanasm.exp
> https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01600.html
> - [testsuite] Fix "too few/many" error messages in scan-*-times procs
> https://gcc.gnu.org/ml/gcc-patches/2018-05/msg01601.html
>
> The output of the test run is:
> ...
> Running
> /home/vries/gcc_versions/devel/src/gcc/testsuite/gcc.dg-selftests/dg-final.exp
> ...
> PASS: scan-tree-dump 0 1 2 3: too many arguments
> PASS: scan-tree-dump 0: too few arguments
> PASS: scan-tree-dump-times 0 1 2 3 4: too many arguments
> PASS: scan-tree-dump-times 0 1: too few arguments
> PASS: scan-tree-dump-not 0 1 2 3: too many arguments
> PASS: scan-tree-dump-not 0: too few arguments
> PASS: scan-tree-dump-dem 0 1 2 3: too many arguments
> PASS: scan-tree-dump-dem 0: too few arguments
> PASS: scan-tree-dump-dem-not 0 1 2 3: too many arguments
> PASS: scan-tree-dump-dem-not 0: too few arguments
> PASS: scan-rtl-dump 0 1 2 3: too many arguments
> PASS: scan-rtl-dump 0: too few arguments
> PASS: scan-rtl-dump-times 0 1 2 3 4: too many arguments
> PASS: scan-rtl-dump-times 0 1: too few arguments
> PASS: scan-rtl-dump-not 0 1 2 3: too many arguments
> PASS: scan-rtl-dump-not 0: too few arguments
> PASS: scan-rtl-dump-dem 0 1 2 3: too many arguments
> PASS: scan-rtl-dump-dem 0: too few arguments
> PASS: scan-rtl-dump-dem-not 0 1 2 3: too many arguments
> PASS: scan-rtl-dump-dem-not 0: too few arguments
> PASS: scan-ipa-dump 0 1 2 3: too many arguments
> PASS: scan-ipa-dump 0: too few arguments
> PASS: scan-ipa-dump-times 0 1 2 3 4: too many arguments
> PASS: scan-ipa-dump-times 0 1: too few arguments
> PASS: scan-ipa-dump-not 0 1 2 3: too many arguments
> PASS: scan-ipa-dump-not 0: too few arguments
> PASS: scan-ipa-dump-dem 0 1 2 3: too many arguments
> PASS: scan-ipa-dump-dem 0: too few arguments
> PASS: scan-ipa-dump-dem-not 0 1 2 3: too many arguments
> PASS: scan-ipa-dump-dem-not 0: too few arguments
> PASS: scan-ltrans-tree-dump 0 1 2 3: too many arguments
> PASS: scan-ltrans-tree-dump 0: too few arguments
> PASS: scan-ltrans-tree-dump-times 0 1 2 3 4: too many arguments
> PASS: scan-ltrans-tree-dump-times 0 1: too few arguments
> PASS: scan-ltrans-tree-dump-not 0 1 2 3: too many arguments
> PASS: scan-ltrans-tree-dump-not 0: too few arguments
> PASS: scan-ltrans-tree-dump-dem 0 1 2 3: too many arguments
> PASS: scan-ltrans-tree-dump-dem 0: too few arguments
> PASS: scan-ltrans-tree-dump-dem-not 0 1 2 3: too many arguments
> PASS: scan-ltrans-tree-dump-dem-not 0: too few arguments
> PASS: scan-wpa-ipa-dump 0 1 2 3: too many arguments
> PASS: scan-wpa-ipa-dump 0: too few arguments
> PASS: scan-wpa-ipa-dump-times 0 1 2 3 4: too many arguments
> PASS: scan-wpa-ipa-dump-times 0 1: too few arguments
> PASS: scan-wpa-ipa-dump-not 0 1 2 3: too many arguments
> PASS: scan-wpa-ipa-dump-not 0: too few arguments
> PASS: scan-wpa-ipa-dump-dem 0 1 2 3: too many arguments
> PASS: scan-wpa-ipa-dump-dem 0: too few arguments
> PASS: scan-wpa-ipa-dump-dem-not 0 1 2 3: too many arguments
> PASS: scan-wpa-ipa-dump-dem-not 0: too few arguments
> PASS: scan-offload-tree-dump 0 1 2 3: too many arguments
> PASS: scan-offload-tree-dump 0: too few arguments
> PASS: scan-offload-tree-dump-times 0 1 2 3 4: too many arguments
> PASS: scan-offload-tree-dump-times 0 1: too few arguments
> PASS: scan-offload-tree-dump-not 0 1 2 3: too many arguments
> PASS: scan-offload-tree-dump-not 0: too few arguments
> PASS: scan-offload-tree-dump-dem 0 1 2 3: too many arguments
> PASS: scan-offload-tree-dump-dem 0: too few arguments
> PASS: scan-offload-tree-dump-dem-not 0 1 2 3: too many arguments
> PASS: scan-offload-tree-dump-dem-not 0: too few arguments
> PASS: scan-lang-dump 0 1 2 3: too many arguments
> PASS: scan-lang-dump 0: too few arguments
> PASS: object-readelf 0 1 2 3: too many arguments
> PASS: object-readelf 0: too few arguments
> PASS: scan-assembler-times 0 1 2 3: too many arguments
> PASS: scan-assembler-times 0: too few arguments
> PASS: scan-assembler-dem 0 1 2: too many arguments
> PASS: scan-assembler-dem : too few arguments
> PASS: scan-assembler-dem-not 0 1 2: too many arguments
> PASS: scan-assembler-dem-not : too few arguments
> PASS: object-size 0 1 2 3 4: too many arguments
> PASS: object-size 0 1: too few arguments
> PASS: scan-assembler 0 1 2: too many arguments
> PASS: scan-assembler : too few arguments
> PASS: scan-assembler-not 0 1 2: too many arguments
> PASS: scan-assembler-not : too few arguments
> PASS: scan-hidden 0 1 2: too many arguments
> PASS: scan-hidden : too few arguments
> PASS: scan-not-hidden 0 1 2: too many arguments
> PASS: scan-not-hidden : too few arguments
> PASS: scan-file 0 1 2 3: too many arguments
> PASS: scan-file 0: too few arguments
> PASS: scan-file-not 0 1 2 3: too many arguments
> PASS: scan-file-not 0: too few arguments
> PASS: scan-stack-usage 0 1 2: too many arguments
> PASS: scan-stack-usage : too few arguments
> PASS: scan-stack-usage-not 0 1 2: too many arguments
> PASS: scan-stack-usage-not : too few arguments
> PASS: scan-ada-spec 0 1 2: too many arguments
> PASS: scan-ada-spec : too few arguments
> PASS: scan-ada-spec-not 0 1 2: too many arguments
> PASS: scan-ada-spec-not : too few arguments
> PASS: scan-lto-assembler 0 1 2: too many arguments
> PASS: scan-lto-assembler : too few arguments
>
> === gcc Summary ===
>
> # of expected passes 94
> ...
>
> Good or bad idea?
>
> Any other comments?
>
> Ok for trunk?
>
> Thanks,
> - Tom
>
> Add gcc.dg-selftests/dg-final.exp
>
> 2018-05-30 Tom de Vries <t...@codesourcery.com>
>
> * gcc.dg-selftests/dg-final.exp: New file.
OK.
jeff
