On 06/20/2018 09:20 AM, Jakub Jelinek wrote: > On Wed, Jun 20, 2018 at 09:15:08AM -0600, Jeff Law wrote: >>> Thank you for the trust. I tried to split it into multiple patches, but >>> it wasn't readable enough. >> Yea, it can be painful to find the right way to structure a series. In >> fact, I'm going to be faced with that shortly for a target change my son >> and I have in the works (converting v850 away from cc0). In the end it >> looks like 75% of the file changed, but a lot of it is just unidiff >> presenting the changes in a particularly bad way. > > Have you tried diff -upd? -d helps a lot in some cases to make diffs more > readable. It's one of the things I'll look at. It may also be the case that I can stage them in such a way as to keep the diffs reasonable. It may mean a couple revs in the repo where we don't optimize well, but given the target I doubt that's a big deal. This was mostly an exercise to keep my son's mind occupied :-)
Jeff