Hi Carl,
On Wed, Jun 20, 2018 at 05:09:00PM -0700, Carl Love wrote:
> I believe I have addressed all of your concerns with the patch.
>
> I have retested it and it looks good.
It looks good indeed. Please commit, thanks!
I noticed one more thing (follow-up patch?)
> /* { dg-final { scan-assembler-times "divd" 8 { target lp64 } } } */
> /* { dg-final { scan-assembler-times "divdu" 2 { target lp64 } } } */
> /* { dg-final { scan-assembler-times "mulld" 4 { target lp64 } } } */
> -/* { dg-final { scan-assembler-times "bl __divdi3" 3 { target ilp32 } } } */
> -/* { dg-final { scan-assembler-times "bl __udivdi3" 3 { target ilp32 } } }
> */
> +/* { dg-final { scan-assembler-times {\mbl __divdi3\M} 2 { target { ilp32 }
> } } } */
> +/* { dg-final { scan-assembler-times {\mbl __udivdi3\M} 2 { target {ilp32 }
> } } } */
The test for "divd" will count those __divdi3, __udivdi3 as well. It also
counts divdu.
Putting \m\M around most mnemonics helps.
Cheers,
Segher
