On Thu, Jun 21, 2018 at 07:11:37PM -0400, Michael Meissner wrote: > On Thu, Jun 21, 2018 at 06:07:36PM -0500, Segher Boessenkool wrote: > > On Wed, Jun 20, 2018 at 10:54:18AM -0400, Michael Meissner wrote: > > > This patch fixes the tests in the testsuite that implicitly were > > > expecting long > > > double to be IBM extended double to use __ibm128 if long double is > > > configured > > > to be IEEE 128-bit floating point. > > > > And just always using __ibm128 does not work? That needs fixing then. > > As we've discussed before, __ibm128 is only created when the float128 support > is enabled (VSX and Linux). If I changed the tests without adding a condition > to only run it on the appropriate systems, it would give errors on AIX, and > 32-bit embedded systems.
See the next lines: > > (Perhaps test long double in a separate testcase, too, then, and only run > > that if the appropriate long double type is active). So, have a test for long double (gated on when long double is an appropriate type for those tests), and one for __ibm128 (with a quite different condition for those). Segher
