Hi!

On Mon, Jul 09, 2018 at 02:08:37PM -0500, Will Schmidt wrote:
>       * config/rs6000/rs6000.c (rs6000_gimple_fold_builtin):
>       Add support for gimple-folding of vec_pack() and vec_unpack()
>       intrinsics.

> +    case ALTIVEC_BUILTIN_VUPKHPX:
> +    case ALTIVEC_BUILTIN_VUPKLPX:
> +      {
> +       return false;
> +      }

A block around a signle statement looks a bit silly (and in the other
cases in your patch it isn't necessary either; it is nice if you use it
to give some scope to a local var, but you don't have that here).

But, patch is fine as far as I can see :-)


Segher

Reply via email to