On 07/13/2018 06:32 PM, Kyrill Tkachov wrote:
This looks good to me modulo a couple of minor comments inline.
You'll still need an approval from a maintainer.
Thanks, I'll send a fixed up version on Monday.
+ for (ause= DF_REG_USE_CHAIN (regno); ause; ause = DF_REF_NEXT_REG
(ause))
+ {
Space after ause
OK.
+ /* Falkor does not support SVE vectors. */
+ gcc_assert (GET_MODE_SIZE (mode).is_constant ());
+
I think this will blow up if someone tries compiling for SVE
(-march=armv8.2-a+sve for example)
with -mtune=falkor. We don't want to crash then. I believe you just want
to bail out of the optimisation by returning false.
You should update the comment in tag () to reflect this as well.
OK.
Thanks,
Siddhesh
