On Fri, Jul 13, 2018 at 7:15 PM Carl Love <c...@us.ibm.com> wrote:
>
> On Fri, 2018-07-13 at 16:00 -0500, Segher Boessenkool wrote:
> > On Fri, Jul 13, 2018 at 10:51:24AM -0400, David Edelsohn wrote:
> > > On AIX it would be calling divtc3, but AIX defaults to 64 bit long
> > > double.  Either all of these tests need
> > >
> > > /* { dg-require-effective-target longdouble128 } */
> > >
> > > or
> > >
> > > /* { dg-additional-options "-mlong-double-128" { target powerpc-
> > > ibm-aix* } } */
> > >
> > > along with testing for "tc", e.g., bl .__divtc3
> >
> > Which would you prefer David?  (I'd do the former).
> >
> >
> > Segher
> >
>
> Segher, David:
>
> I reworked the patch per the first option that David gave.  The tests
> divkc3-2.c, divkc3-3.c, mulkc3-2.c and mulkc3-3.c pass on Power 9 Linux
> as they did before.  The tests are unsupported on Power8 Linux as they
> were before.  Now, the tests are reported as unsupported on AIX rather
> then failing on AIX.
>
> Please let me know if you both approve the updated patch below.  Thanks
> for the input and help on this.
>
>                    Carl Love
>
> -----------------------------------------------------------------------
>
> gcc/testsuite/ChangeLog:
>
> 2018-07-13  Carl Love  <c...@us.ibm.com>
>
>         * gcc.target/powerpc/divkc3-2.c: Add dg-require-effective-target
>         longdouble128.
>         * gcc.target/powerpc/divkc3-3.c: Ditto.
>         * gcc.target/powerpc/mulkc3-2.c: Ditto.
>         * gcc.target/powerpc/mulkc3-3.c: Ditto.
>         * gcc.target/powerpc/fold-vec-mergehl-double.c: Update counts.
>         * gcc.target/powerpc/pr85456.c: Make check Linux and AIX specific.
> ---
>  gcc/testsuite/gcc.target/powerpc/divkc3-2.c                | 1 +
>  gcc/testsuite/gcc.target/powerpc/divkc3-3.c                | 1 +
>  gcc/testsuite/gcc.target/powerpc/fold-vec-mergehl-double.c | 4 +---
>  gcc/testsuite/gcc.target/powerpc/mulkc3-2.c                | 1 +
>  gcc/testsuite/gcc.target/powerpc/mulkc3-3.c                | 1 +
>  gcc/testsuite/gcc.target/powerpc/pr85456.c                 | 3 ++-
>  6 files changed, 7 insertions(+), 4 deletions(-)

Hi, Carl

This is essentially what I have been testing with today.

This is okay.

Thanks, David

Reply via email to