> On Jul 26, 2018, at 3:26 AM, Richard Biener <rguent...@suse.de> wrote: > > On Wed, 25 Jul 2018, Qing Zhao wrote: > >> Hi, >> >> As Wilco suggested, the new added strcmp/strncmp inlining should be only >> enabled with O2 and above. >> >> this is the simple patch for this change. >> >> tested on both X86 and aarch64. >> >> Okay for thunk? > > You should simply use > > if (optimize_insn_for_size_p ()) > return NULL_RTX; > > to be properly profile-aware. OK with that change.
thanks for the review. I will make the change, retest it, and then commit it. Qing > > Richard. >
