On Sep 5, 2018, at 6:29 AM, Joey Ye <joey...@arm.com> wrote: > This is a fix to an obvious issue in gcov.exp, where proc verify-intermediate > returns without closing the open file. > > This can be a possible fix to PR85871. gcov-8.C diffs to other gcov testcases > that it invokes verify-intermediate. Not closing an open file may result in > random failure quietly. > > It is only a possible fix as I failed to reproduce the PR85871 random failure > in my local machine despite continuous testing of multiple days. So I cannot > verify if this patch fixes the regression either. > > To verify, https://gcc.gnu.org/ml/gcc-testresults/ need to be watched whether > gcov-8 regression will disappear completely one month after this patch > committed to trunk. > > Tested with make check with no new regressions. > > OK to trunk?
Ok. I'm hoping that this doesn't fix that issue, as this change should not cause any change to correctly written code. if it does fix it, there is at least one more unfortunate thing that should be fixed that remains unidentified.
