On 12/09/18 16:16, Richard Biener wrote:
I think the symptom GCN sees needs to be better understood - like wheter it is generally OK to mangle things arbitrarily.
The name mangling is a horrible workaround for a bug in the HSA runtime code (which we do not own, cannot fix, and would want to support old versions of anyway). Basically it refuses to load any binary that has the same symbol as another, already loaded, binary, regardless of the symbol's linkage. Worse, it also rejects any binary that has duplicate symbols within it, despite the fact that it already linked just fine.
Adding the extra lookups is enough to build GCN binaries, with mangled names, whereas the existing name mangling support was either more specialized or bit rotten (I don't know which).
It may well be that there's a better way to solve the problem, or at least to do the lookups.
It may also be that there are some unintended consequences, such as false name matches, but I don't know of any at present.
Julian, can you comment, please? Andrew
