On 18/09/18 10:00, Eric Botcazou wrote: >> this seems to contradict your statement above about having to work >> harder to fix up minipools. > > Why? Fixing up minipools is done in the generic ARM reorg pass, not in the > Thumb reorg pass(es). >
Ah! But that still doesn't explain why you want to skip these passes when building thunks. >> Why do we need a barrier here unconditionally (ie in the non-longcall case)? > > We don't, but it doesn't harm to put it either. For example, the x86, > PowerPC > and SPARC ports always do it. > So is the barrier correct, or isn't it? There's really no two ways about this. I don't like arbitrary changes that are justified solely on 'that's what another port does'. R.
