On Mon, Sep 24, 2018 at 08:40:13PM +0200, Martin Jambor wrote: > Hi, > > the warning for suspicious calls of abs-like functions segfaults if a > user declared their own parameter-less-ish variant of abs like in the > testcase below. Fixed by looking whether there is any TYPE_ARG_TYPES > before trying to compare the actual argument with it. > > Bootstrapped and tested on x86_64-linux and aarch64-linux, the same on > i686-linux is pending. > > OK for trunk?
Isn't that bail out too early? I mean most of the warnings that are emitted by the function don't really need TYPE_ARG_TYPES, only the last one does, so can't you just bail out before the last warning? Also, the function comment has "gracely", did you mean "gracefully"? Jakub