On Wed, 26 Sep 2018, Qing Zhao wrote: > I don’t think a -Os-like option will do the job. > > As Jeff already mentioned in a very previous email: > > “Presumably one of the cases where this capability is really helpful is > things like ksplice. If you have a function with global scope that has > been potentially inlined, then it's a lot harder track down those > inlining points at DTRT. > > We ran into this internally when looking at hot patching some of the > spinlock code in the kernel. It would have been real helpful if the > kernel had been compiled with this kind of option :-) > > So conceptually I can see value in this kind of option. > “ > > so, specially control inlining on static/global will be helpful to online > patch.
In addition to what Richard said, I don't follow this reasoning. The issue with spinlock functions is that many of them are defined in header files and get inlined everywhere, correct? But such functions are all 'static inline', so this patch wouldn't affect them at all. Alexander
