On Mon, Oct 22, 2018 at 5:00 AM, Martin Liška <mli...@suse.cz> wrote: > On 10/19/18 1:02 AM, Ian Lance Taylor wrote: >> On Sat, Sep 22, 2018 at 12:08 PM, marxin <mli...@suse.cz> wrote: >>> >>> gcc/go/ChangeLog: >>> >>> 2018-09-24 Martin Liska <mli...@suse.cz> >>> >>> * gofrontend/escape.cc (Gogo::analyze_escape): Remove >>> usage of a parameter. >>> (Gogo::assign_connectivity): Likewise. >>> (class Escape_analysis_tag): Likewise. >>> (Gogo::tag_function): Likewise. >>> * gofrontend/expressions.cc (Call_expression::do_type): Likewise. >>> * gofrontend/gogo.h (class Gogo): Likewise. >>> * gofrontend/types.cc (class Call_multiple_result_type): Likewise. >>> (Type::make_call_multiple_result_type): Likewise. >>> * gofrontend/types.h (class Type): Likewise. >>> * gofrontend/wb.cc (class Check_escape): Likewise. >>> (Gogo::add_write_barriers): Likewise. >> >> HI, unfortunately this is wrong. As described in >> gcc/go/gofrontend/README, the files in that directory are mirrored >> from a separate repository (the same is true of the files in the libgo >> directory). You should not make changes to them directly in the GCC >> repository. I have reverted these changes, as follows. Sorry. >> >> Ian >> > > Hi Ian. > > Got it. Is it possible that the removed chunks of code are somehow alive > in original repository in some conditional build?
No, I doubt it, but I'd also want to consider the changes separately. There is benefit to consistency even if it leads to unused variables. Ian