On 10/30/18 4:35 PM, Stafford Horne wrote:
> On Tue, Oct 30, 2018 at 10:49:53AM -0500, Segher Boessenkool wrote:
>> On Tue, Oct 30, 2018 at 09:49:18PM +0900, Stafford Horne wrote:
>>> Hello,
>>>
>>> On Sun, Oct 28, 2018 at 05:54:47PM -0500, Segher Boessenkool wrote:
>>>> Yes, like that. It also easily can handle the other combos (those with
>>>> STACK_POINTER), and it is easier if you have to switch FRAME_GROWS_DOWNWARD
>>>> ("false" is better on some args, but "true" is required for ssp).
>>>>
>>>> Your code is fine as-is of course.
>>>
>>> Just to be clear, when you say 'as-is' did you mean the original v3 patch?
>>> Or
>>> are you referring to followup patch I posted with the some_offset (from) -
>>> some_offset (to) logic.
>>
>> Either. Both. I meant the orig big patch, v3 if that's what it was.
>
> Alright, thanks, I just didnt want to misunderstand.
Also note that it's my understanding the issues I raised during my
review have been dealt with as have Joseph's. My inclination would be
to accept the port when Stafford & rth think it's ready.
Jeff
