On Thu, 1 Nov 2018, Rainer Orth wrote:

> * One for ia64 in gcc_cv_as_ia64_ltoffx_ldxmov_relocs) ...
> 
>     $as_echo '        .text
>       addl r15 = @ltoffx(x#), gp
>       ;;
>       ld8.mov r16 = [r15], x#'[] > conftest.s

Thanks for pointing this out.  I've applied this patch to fix this by 
adding a newline at the end of the test input (which is what I did for all 
the cases where adding AC_LANG_SOURCE resulted in autoconf errors if the 
last line of the AC_LANG_SOURCE argument contained '#'; I don't know how 
related the issues are, but it's at least less cryptic for the reader than 
using a quadrigraph).


Avoid stray [] in ia64 assembler test.

Noted in <https://gcc.gnu.org/ml/gcc-patches/2018-11/msg00034.html>.
Fix by adding extra newline in test input is analogous to many such
newlines added in cases where argument to a newly added AC_LANG_SOURCE
had a preprocessor directive on its last line.

2018-11-01  Joseph Myers  <jos...@codesourcery.com>

        * configure.ac (gcc_cv_as_ia64_ltoffx_ldxmov_relocs): Add newline
        at end of assembler input text.
        * configure: Regenerate.

Index: configure
===================================================================
--- configure   (revision 265722)
+++ configure   (working copy)
@@ -26646,7 +26646,8 @@
     $as_echo ' .text
        addl r15 = @ltoffx(x#), gp
        ;;
-       ld8.mov r16 = [r15], x#'[] > conftest.s
+       ld8.mov r16 = [r15], x#
+' > conftest.s
     if { ac_try='$gcc_cv_as $gcc_cv_as_flags  -o conftest.o conftest.s >&5'
   { { eval echo "\"\$as_me\":${as_lineno-$LINENO}: \"$ac_try\""; } >&5
   (eval $ac_try) 2>&5
Index: configure.ac
===================================================================
--- configure.ac        (revision 265722)
+++ configure.ac        (working copy)
@@ -4550,7 +4550,8 @@
 [      .text
        addl r15 = @ltoffx(x#), gp
        ;;
-       ld8.mov r16 = [[r15]], x#],,
+       ld8.mov r16 = [[r15]], x#
+],,
     [AC_DEFINE(HAVE_AS_LTOFFX_LDXMOV_RELOCS, 1,
          [Define if your assembler supports ltoffx and ldxmov relocations.])])
 

-- 
Joseph S. Myers
jos...@codesourcery.com

Reply via email to