On 11/5/18 12:36 PM, Peter Bergner wrote: > On 11/5/18 1:20 PM, Jeff Law wrote: >> On 11/1/18 4:07 PM, Peter Bergner wrote: >>> On 11/1/18 1:50 PM, Renlin Li wrote: >>>> Is there any update on this issues? >>>> arm-none-linux-gnueabihf native toolchain has been mis-compiled for a >>>> while. >>> >>> From the analysis I've done, my commit is just exposing latent issues >>> in LRA. Can you try the patch I submitted here to see if it helps? >>> >>> https://gcc.gnu.org/ml/gcc-patches/2018-10/msg01757.html >>> >>> It survives on powerpc64le-linux, x86_64-linux and s390x-linux. >>> Jeff threw it on his testers and said he saw an arm issue and was >>> trying to come up with a test case for me to debug. >> So I don't think the ARM issues are related to your patch, they may have >> been related the combiner changes that went in around the same time. >> >> At this point your patch appears to be DTRT across the board. The only >> fallout is the bogus s390 asm it caught in the kernel. > > Cool. I will note that I contacted the s390 kernel guys and gave them a > fix to their broken constraints in that asm and they are going to fix it. Sounds good. I've got a hack in my tester to "fix" that bogus asm until the kernel folks do it right.
> > Is the above an approval to commit the patch mentioned above or do you > still want to wait until the ARM issues are fully resolved? I think knowing the patch addresses all the known issues related to the earlier IRA/LRA change unblocks the review step. I don't think we need to wait for the other ARM issues to be resolved -- they seem to be unrelated to the IRA/LRA changes. jeff
