On 11/6/18 7:55 PM, Jeff Law wrote: > On 11/6/18 7:05 AM, Martin Liška wrote: >> Hi. >> >> The patch is adding a check overflow in eliminate_partially_redundant_load. >> Question is whether the usage of conditional compilation of >> __builtin_mul_overflow >> is fine? >> >> Thanks, >> Martin >> >> gcc/ChangeLog: >> >> 2018-11-06 Martin Liska <mli...@suse.cz> >> >> PR rtl-optimization/87868 >> * postreload-gcse.c (eliminate_partially_redundant_load): Set >> threshold to max_count if we would overflow. >> * profile-count.h: Make max_count a public constant. > OK. Though I do worry about how many of these things we'll have to > sprinkle over the sources over time. I suspect there's all kinds of > overflows just waiting to happen, some are obviously more important than > others.
Sure! Btw. I've been preparing patch that will limit some of --param values as they tent to overlap if a user selects a big-enough value. Martin > > jeff >
