Hi, On Thu, 8 Nov 2018, Martin Liška wrote:
> > That seems better. But still, why declare this in system.h? It seems > > hash-table.h seems more appropriate. > > I need to declare it before I'll poison it. As system.h is included very > early, one can guarantee that there will be no usage before the > poisoning happens. Yes but it's also included everywhere, so adding anything to it comes at a cost, and conceptually it simply doesn't belong there. There's no fundamental reason why we can't poison identifiers in other headers. Indeed we do in vec.h. So move the whole thing including poisoning to hash-table.h? Ciao, Michael.
