On 11/15/18 4:38 AM, Robin Dapp wrote: >> This looks pretty reasonable. ISTM it ought to be able to go forward if >> it's tested independently. > > The test suite already passes, any other tests you have in mind? To be > honest I suppose noce_convert_multiple_sets will currently never > successfully return (due to the costing problems I described before), so > a specific test case might be difficult. There can be subtle dependencies on prior patches when you test it as part of a set. If we're going to gate this in independently, then it should be tested independently.
Jeff