On Thu, 22 Nov 2018, Jonathan Wakely wrote:

On 26/10/18 14:02 +0200, Marc Glisse wrote:
Index: libstdc++-v3/include/bits/stl_iterator.h
===================================================================
--- libstdc++-v3/include/bits/stl_iterator.h    (revision 265522)
+++ libstdc++-v3/include/bits/stl_iterator.h    (working copy)
@@ -59,20 +59,24 @@

#ifndef _STL_ITERATOR_H
#define _STL_ITERATOR_H 1

#include <bits/cpp_type_traits.h>
#include <ext/type_traits.h>
#include <bits/move.h>
#include <bits/ptr_traits.h>

#if __cplusplus > 201402L

I think this should be >= 201103L, no?

Ah, yes, I guess I started from a copy-paste and got interrupted before updating it :-(

OK for trunk (with that #if changed, if appropriate).

Thanks. Re-tested and committed. Do you have an opinion on the following item, which may be a bug in the current code?

"For __relocate_a_1, I should also test if copying, ++ and != are noexcept, but I wanted to ask first because there might be restrictions on what iterators are allowed to do, even if I didn't see them."

--
Marc Glisse

Reply via email to