On 11/27/18 11:46 AM, Segher Boessenkool wrote: > On Mon, Nov 26, 2018 at 01:41:07PM -0700, Jeff Law wrote: >> On 11/26/18 10:59 AM, Martin Sebor wrote: >>> As an aside, regarding the space convention in casts: a crude >>> grep search yields about 10,000 instances of the "(type)x" kinds >>> of casts in GCC sources and 40,000 of the preferred "(type) x" >>> style with the space. That's a consistency of only 80%. Is >>> it worth documenting a preference for a convention that's so >>> inconsistently followed? >> Please do. It's a fairly recent change -- I suspect some old code was >> never fixed and some folks (perhaps myself) have that extraneous >> whitespace in their muscle memory and still need to eliminate it. > > Huh? Spaces after casts are required, and make things much more > readable. This isn't recent. > > A lot of old code writes spaces after single-character unary operators, > too, which is ugly and less readable. It's not recent that this is > explicitly documented as wrong, either. Sorry. Got confused with something else.
jeff
