On Wed, 28 Nov 2018 at 22:32, Johannes Pfau <johannesp...@gmail.com> wrote: > > Next version, addresses the review comments. > > Tested at https://github.com/D-Programming-GDC/GDC/pull/768 > --- > gcc/d/ChangeLog: > > 2018-11-28 Johannes Pfau <johannesp...@gmail.com> > > * expr.cc (ExprVisitor::visit(IdentityExp)): Add support for complex > types. > (build_float_identity): New function. > > gcc/testsuite/ChangeLog: > > 2018-11-28 Johannes Pfau <johannesp...@gmail.com> > > * gdc.dg/runnable.d: Test IdentityExp for complex types. > > > gcc/d/expr.cc | 40 ++++++++++++++++++++++++--------- > gcc/testsuite/gdc.dg/runnable.d | 22 ++++++++++++++++++ > 2 files changed, 51 insertions(+), 11 deletions(-) >
As I've said before, looks reasonable to me. Thanks. -- Iain