On 28/11/18 12:12 -0500, Ed Smith-Rowland wrote:
Index: testsuite/21_strings/basic_string/erasure.cc =================================================================== --- testsuite/21_strings/basic_string/erasure.cc (nonexistent) +++ testsuite/21_strings/basic_string/erasure.cc (working copy) @@ -0,0 +1,53 @@ +// { dg-do run { target c++2a } } +
None of these new tests actually run by default, because they are gated to only run for C++2a and the default is gnu++14. That means they're all skipped as UNSUPPORTED. (When I add new tests I always try to remember to check the testsuite/libstdc++.sum file to make sure they are actually running). The tests need an explicit -std option added via dg-options, which has to come before the dg-do directive, otherwise the target check still uses the default options i.e. // { dg-options "-std=gnu++2a" } // { dg-do run { target c++2a } } With that added, most of them start to FAIL: FAIL: 23_containers/deque/erasure.cc (test for excess errors) UNRESOLVED: 23_containers/deque/erasure.cc compilation failed to produce executable FAIL: 23_containers/unordered_set/erasure.cc (test for excess errors) UNRESOLVED: 23_containers/unordered_set/erasure.cc compilation failed to produce executable FAIL: 23_containers/vector/erasure.cc (test for excess errors) UNRESOLVED: 23_containers/vector/erasure.cc compilation failed to produce executable FAIL: experimental/deque/erasure.cc (test for excess errors) UNRESOLVED: experimental/deque/erasure.cc compilation failed to produce executable FAIL: experimental/forward_list/erasure.cc (test for excess errors) UNRESOLVED: experimental/forward_list/erasure.cc compilation failed to produce executable FAIL: experimental/list/erasure.cc (test for excess errors) UNRESOLVED: experimental/list/erasure.cc compilation failed to produce executable FAIL: experimental/vector/erasure.cc (test for excess errors) UNRESOLVED: experimental/vector/erasure.cc compilation failed to produce executable The errors are all like: In file included from /home/jwakely/src/gcc/gcc/libstdc++-v3/testsuite/23_containers/vector/erasure.cc:21: /home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/vector: In function 'void std::erase_if(std::vector<_Tp, _Alloc>&, _Predicate)': /home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/vector:101: error: 'remove_if' is not a member of 'std'; did you mean 'remove_cv'? /home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/vector: In function 'void std::erase(std::vector<_Tp, _Alloc>&, const _Up&)': /home/jwakely/src/gcc/build/x86_64-pc-linux-gnu/libstdc++-v3/include/vector:109: error: 'remove' is not a member of 'std'; did you mean 'move'? This is because std::remove and std::remove_if are defined in <bits/stl_algo.h> which is not included. Could you please fix this ASAP?