On Thu, 20 Sep 2018 10:05:30 -0700 Cesar Philippidis <ce...@codesourcery.com> wrote:
> Attached is an old gomp4 patch that allegedly fixes an shutdown > runtime issue involving OpenACC accelerators. Unfortunately, the > original patch didn't include a test case, nor did it generate any > regressions in the libgomp testsuite when I reverted it in og8. > > With that said, I like how this patch eliminates the redundant use of > gomp_mutex_lock to unmap variables (because gomp_unmap_vars already > acquires a lock). However, the trade-off is that it does increase > tgt->list_count to num_funcs + num_vars. > > Does anyone have any strong opinion on this patch and is it OK for > trunk? I bootstrapped and regtested it for x86_64 Linux with nvptx > offloading and I didn't encounter any regressions. I'd like to withdraw this patch (on behalf of Cesar, who has left Mentor). It's been superseded by: https://gcc.gnu.org/ml/gcc-patches/2018-11/msg02556.html Thanks, Julian
