On 03/12/2018 09:59, Jakub Jelinek wrote: > On Mon, Dec 03, 2018 at 09:55:36AM +0000, Ramana Radhakrishnan wrote: >> + if (aarch64_stack_protector_guard == SSP_GLOBAL >> + && opts->x_aarch64_stack_protector_guard_offset_str) >> + { >> + error ("Incompatible options -mstack-protector-guard=global and" > > Diagnostic messages shouldn't start with capital letters (3 times in the > patch), unless it is something that is capitalized always, even in the > middle of sentences (say GNU etc.). > > Jakub > Sorry - will fix in next iteration.
Ramana