On 04-12-18 13:29, Jakub Jelinek wrote: > On Fri, Jun 29, 2018 at 11:19:53AM -0700, Cesar Philippidis wrote: >> The attached patch includes the nvptx and GCC ME reductions enhancements. >> >> Is this patch OK for trunk? It bootstrapped / regression tested cleanly >> for x86_64 with nvptx offloading. > This is all OpenACC specific code not really shareable with OpenMP, if > Thomas (for middle-end) and Tom (for NVPTX backend) are ok with it, it is ok > for trunk. >
Formatting needs to be fixed: ... There should be exactly one space between function name and parenthesis. 160:+ unsigned old_shift = DIM_SIZE(VECTOR); ... Also, the updated patch does not address my comment about probabilities here ( https://gcc.gnu.org/ml/gcc-patches/2018-10/msg00325.html ): ... > + /* Create the loop. */ > + post_edge->flags ^= EDGE_TRUE_VALUE | EDGE_FALLTHRU; Edges need probabilities, as in nvptx_lockless_update, nvptx_lockfull_update and nvptx_goacc_reduction_init. ... Thanks, - Tom
