On Wed, Dec 05, 2018 at 05:10:07PM +0000, Iain Sandoe wrote:
> Hi,
>
> The PR is about unnecessary saves of the pic base register, it shows on m32
> Linux and m32/m64 Darwin.
>
> The fix is to check that we are in a pic mode and that the picbase has
> actually been used.
> As a bonus, some #ifdef’d TARGET_MACHO code is no longer required.
>
> Tested on power7, bootstrapped on Darwin (testing continues).
>
> OK for trunk?
Okay for trunk if testing completes successfully :-) Thanks!
> Branches?
Sure. Please let is soak on trunk for a week first; and don't do 7
until 7.4 has been made?
> 2018-xx-xx Segher Boessenkool <seg...@kernel.crashing.org>
> Iain Sandoe <i...@sandoe.co.uk>
>
> gcc/
> * config/rs6000/rs6000.c (save_reg_p): Do not save the picbase reg
> unless it has been used. (first_reg_to_save): Remove dead code.
Your changelogs still wrap (the second "(" should start a new line).
Segher
