On Wed, Dec 19, 2018 at 06:28:29PM +0100, Richard Biener wrote: > On Wed, Dec 19, 2018 at 4:41 PM Andi Kleen <a...@linux.intel.com> wrote: > > > > > > We can combine the two together, increasing iteration count and > > > > decreasing perf count at the same time. What count would you suggest > > > > from your experience? > > > > > > Can we instead for the tests where we want to test profile use/merge > > > elide the profiling step and supply the "raw" data in an testsuite > > > alternate > > > file instead? > > > > That would be possible, but a drawback is that we wouldn't have an > > "end2end" test anymore that also tests the interaction with perf > > and autofdo. Would be good to test these cases too, there were regressions > > in this before. > > Sure. > > > But perhaps splitting that into two separate tests is reasonable, > > with the majority of tests running with fake data. > > > > This would have the advantage that gcc developers who don't > > have an autofdo setup (e.g. missing tools or running in virtualization > > with PMU disabled) would still do most of the regression tests. > > Yes, I think the pros outweight the cons here. Well, at least if > generating such data that works on multiple archs is even possible?
The gcov data that comes out of autofdo is architecture independent as far as I know. It's mainly counts per line. In fact even the perf input data should be fairly architecture independent (except perhaps for endian) I think it would need a way to write gcov data using text input (unless you want to put a lot of binaries into the repository) Also it would need to be adjusted every time a line number changes in the test cases. I guess best would be if dejagnu could somehow generate it from test case comments, but I don't know how complicated that would be. Doing such updates would be likely difficult with binaries. In the future if we ever re-add discriminator support again it would also need some way to specify the correct discriminator. I guess for simple test cases it could be ensured it is always 0. -Andi
