Hi, I updated the patch to address Wilco's comment and style issues.
Alejandro > -----Original Message----- > From: Wilco Dijkstra <wilco.dijks...@arm.com> > Sent: 08 January 2019 16:58 > To: GCC Patches <gcc-patches@gcc.gnu.org>; Alejandro Martinez Vicente > <alejandro.martinezvice...@arm.com> > Cc: nd <n...@arm.com>; Richard Sandiford <richard.sandif...@arm.com> > Subject: Re: [Aarch64][SVE] Add copysign and xorsign support > > Hi Alejandro, > > + emit_move_insn (mask, > + aarch64_simd_gen_const_vector_dup > (<V_INT_EQUIV>mode, > + HOST_WIDE_INT_M1U > + << bits)); > + > + emit_insn (gen_and<v_int_equiv>3 (sign, arg2, mask)); > > Is there a reason to emit separate moves and then requiring the optimizer to > combine them? The result of aarch64_simd_gen_const_vector_dup can be > used directly in the gen_and for all supported floating point types. > > Cheers, > Wilco
copysign_2.patch
Description: copysign_2.patch
