> > Yes, but please test the compiler after the revert. Please also create > > a runtime testcase out of the testcase in the PR. Yes, we have tested it but current runtime testcase can't cover the corner case to expose the incorrectness of SDM. We will add some after the revert.
> For r267160, I'd expect you want to revert just the config/i386/ part and > keep the testcases, they should work even with the changes reverted, right? > The testcase part also need to be reverted since we have changed them according to the incorrect intrinsic list in SDM. Jakub Jelinek <ja...@redhat.com> 于2019年1月15日周二 下午11:20写道： > > On Tue, Jan 15, 2019 at 04:14:06PM +0100, Uros Bizjak wrote: > > On Tue, Jan 15, 2019 at 3:40 PM Wei Xiao <wei.william.x...@gmail.com> wrote: > > > > > > Hi, > > > > > > It turns out that the Intel 64 and IA-32 Architectures Software Developer > > > Manuals (SDM) description about the fixupimm intrinsic is incorrect. So > > > we need > > > to revert 3 patches related to it: r265827, r266026 and r267160. > > > Sorry for the inconvenience. > > > > > > Is it ok? > > > > Yes, but please test the compiler after the revert. Please also create > > a runtime testcase out of the testcase in the PR. > > For r267160, I'd expect you want to revert just the config/i386/ part and > keep the testcases, they should work even with the changes reverted, right? > > Jakub
