Hi Gerald, Updated version, please review.
Thanks. On Mon, Jan 14, 2019 at 7:46 AM Gerald Pfeifer <ger...@pfeifer.com> wrote: > > Hi Paul, > > On Mon, 31 Dec 2018, Paul Hua wrote: > > The attached patch mention Loongson 3a1000 3a2000 3a3000 2k1000 support > > in gcc9. > > thanks for putting this together. Only a couple of editorial changes: > > Index: changes.html > =================================================================== > + <li> > + The Loongson <code>loongson-mmi</code> and <code>loongson-ext</code> > + extension has now been splited from <code>loongson3a</code>: > > "...extensions have been split..." > > + <ul> > + <li><code>loongson-mmi</code> which contains > + the Loongson MultiMedia extension Instructions operations.</li> > + <li><code>loongson-ext</code> which contains > + the Loongson EXTension instructions.</li> > > Here I'd omit omit the two instances of "which" > > + The Loongson EXTension R2 instructions is now supported. > > "is" -> "are" > > + Use -mxxx or -mno-xxx will enable or disable those extersions. > > Since it's only two options, how about listing both of them? > > "extersion" -> "extension" > > + for example: Using > <code>-mloongson-mmi</code>/<code>-mno-loongson-mmi</code> > + will enable/disable Loongson MultiMedia Instructions extensions. > > "...the Loongson MultiMedia Instructions extension." > > + which default enable <code>loongson-mmi</code>, > <code>loongson-ext</code>.</li> > > "which enables ... by default" (also in the following two items) > > > Please look into those comments and then simply post the updated patch > as you're committing it. > > Gerald
Index: changes.html =================================================================== RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-9/changes.html,v retrieving revision 1.35 diff -u -r1.35 changes.html --- changes.html 15 Jan 2019 13:17:49 -0000 1.35 +++ changes.html 17 Jan 2019 02:03:20 -0000 @@ -261,6 +261,45 @@ </li> </ul> +<h3 id="mips">MIPS</h3> +<ul> + <li> + The Loongson <code>loongson-mmi</code> and <code>loongson-ext</code> + extensions have been split from <code>loongson3a</code>: + <ul> + <li><code>loongson-mmi</code> contains + the Loongson MultiMedia extension Instructions operations.</li> + <li><code>loongson-ext</code> contains + the Loongson EXTension instructions.</li> + </ul> + <li> + The Loongson EXTension R2 instructions are now supported. + <ul> + <li><code>loongson-ext2</code> which contains the Loongson EXTension R2 instructions.</li> + </ul> + Use <code>-m[no-]loongson-mmi</code> <code>-m[no-]loongson-ext</code> <code>-m[no-]loongson-ext2</code> + will enable or disable those extensions, + for example: Using <code>-mloongson-mmi</code>/<code>-mno-loongson-mmi</code> + will enable/disable the Loongson MultiMedia Instructions extensions. + <li> + Support has been added for the following processors + (GCC identifiers in parentheses): + <ul> + <li>Loongson 3A1000 (<code>gs464</code>) + which enables <code>loongson-mmi</code>, <code>loongson-ext</code> by default.</li> + <li>Loongson 3A2000/3A3000 (<code>gs464e</code>) + which enables <code>loongson-mmi</code>, <code>loongson-ext</code>, <code>loongson-ext2</code> by default.</li> + <li>Loongson 2K1000 (<code>gs264e</code>) + which enables <code>loongson-ext</code>, <code>loongson-ext2</code>, <code>msa</code> by default.</li> + </ul> + The GCC identifiers can be used + as arguments to the <code>-mcpu</code> or <code>-mtune</code> options, + for example: <code>-mcpu=gs464</code> or + <code>-mtune=gs464e</code> or as arguments to the equivalent target + attributes and pragmas. + </li> +</ul> + <!-- <h3 id="hsa">Heterogeneous Systems Architecture</h3> --> <!-- <h3 id="x86">IA-32/x86-64</h3> -->
