On 20/01/2019 15:48, Segher Boessenkool wrote: > Hi! > > On Thu, Jan 17, 2019 at 03:02:00PM +0000, Tamar Christina wrote: >> This test was added back when builtins were being used instead of ACLE >> intrinsics. The test as far as I can tell is really testing vcombine, >> however some of these builtins no longer exist and causes an ICE. >> >> This fixes the testcase by changing it to use neon intrinsics.
JFTR, I think this was a case when we were using builtins for implementation of the ACLE intrinsics and the testcase was reduced to remove the use of arm_neon.h . Thus the test needs to go back to using the neon intrinsics directly if possible. Also if there are other tests like this it would be a good small cleanup to do. > > Shouldn't the ICE be fixed as well? [ Sorry if you send a separate patch > for that and I missed it ]. > Indeed but that's a separate issue to this. regards Ramana > > Segher >