On Tue, Jan 29, 2019 at 9:20 PM Steve Kargl <s...@troutmask.apl.washington.edu> wrote: > > On Tue, Jan 29, 2019 at 08:46:40PM +0100, Uros Bizjak wrote: > > > > When changing trap masks, it is necessary to clear pending traps to > > prevent firing spurious interrupts. Attached patch also optimizes > > set_fpu_trap_exceptions function considerably to only call > > feenableexcept and fedisableexcept functions each once. > > > > 2019-01-29 Uroš Bizjak <ubiz...@gmail.com> > > s/Uro/Uros ?
No, the original is correct. It is probably your mailer skipping non-ascii characters. > > * config/fpu-glibc.h (set_fpu_trap_exceptions): Clear stalled > > exception flags before changing trap mode. Optimize to call > > feenableexcept and fedisableexcept only once. > > > > Patch was bootstrapped and regression tested on alphaev68-linux-gnu, > > where it fixes gfortran.dg/ieee/ieee_10.f90 failures. > > > > OK for mainline? > > > > Uros, > > Your decription suggests that this fixes PR fortran/88678. > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88678 Actually, additional patch is needed to fully fix PR88678. support_fpu_trap enables and disables exceptions and this may fire spurious exceptions. Just assume that all supported flags can generate exceptions, as is done in the additional patch, posted to PR88678. Uros. > I managed to identify that the issue was traceable to fpu-glibc.h, > but I got stuck going any further. > > In any event, the patch looks good to me. > > Thanks. > > -- > steve
