On Tue, Feb 05, 2019 at 08:58:44AM -0600, Bill Seurer wrote: > On 02/05/19 05:31, Segher Boessenkool wrote: > >Do we not want to test this on LE anymore? Oh, P7, heh. Okay. Not > >enough coffee yet :-) > > It will work if I specify -mbig-endian -mabi=elfv1 but yeah, we don't > really care about P7 generating LE code. > > >>+/* { dg-final { scan-assembler-times "xvcmpgedp" 6 } } */ > >>+/* { dg-final { scan-assembler-times "xvcmpgedp." 6 } } */ > >These need fixing still: both of these match > > xvcmpgedp 0,1,2 > >because dot means "any character", in a regexp. Maybe > > > >/* { dg-final { scan-assembler-times {\mxvcmpgedp\s} 6 } } */ > >/* { dg-final { scan-assembler-times {\mxvcmpgedp\.\s} 6 } } */ > > > >(and with the counts fixed). (Same for all other dot insns of course). > > > > A lot of these test cases (as in power-specific opcode tests) test for > both OPCODE and OPCODE. which as you noted matches both. Many others > just test for OPCODE (which will also match OPCODE.). I meant to ask if > that was actually useful as they always matched the same thing either way. > > I will do the updates you recommended. Should I post the updated diffs > or is this enough to submit the patch?
Please repost. Do the "dot" things in a separate patch please, if you have those already anyway. Segher