On Mon, 2019-02-11 at 10:27 -0800, Ian Lance Taylor wrote: > On Mon, Feb 11, 2019 at 3:10 AM Svante Signell <svante.sign...@gmail.com> > wrote: > > On Sun, 2019-02-10 at 22:08 -0800, Ian Lance Taylor wrote: > > > On Sun, Feb 10, 2019 at 3:41 AM Svante Signell <svante.sign...@gmail.com> > > > wrote: > > > > On Sat, 2019-02-09 at 23:57 +0100, Svante Signell wrote: > > > > > On Sat, 2019-02-09 at 14:40 -0800, Ian Lance Taylor wrote: > > > > > > On Fri, Feb 8, 2019 at 3:07 PM Matthias Klose <d...@debian.org> > > > > > > wrote: > > > > > > > On 07.02.19 06:04, Ian Lance Taylor wrote: > > > > > > What are the lines before that in the log? For some reason libtool > > > > > > is > > > > > > being invoke with no source files. The lines before the failing > > > > > > line > > > > > > should show an invocation of match.sh that determines the source > > > > > > files. > > > > > > > > > > Thanks for your job upstreaming the patches! > > > > > > > > > > I've found some problems. Current problem is with the mksysinfo.sh > > > > > patch. > > > > > But there are some other things missing. New patches will be submitted > > > > > tomorrow. > > > > > > > > Attached are three additional patches needed to build libgo on GNU/Hurd: > > > > src_libgo_mksysinfo.sh.diff > > > > src_libgo_go_syscall_wait.c.diff > > > > src_libgo_testsuite_gotest.diff > > > > > > > > For the first patch, src_libgo_mksysinfo.sh.diff, I had to go back to > > > > the > > > > old version, using sed -i -e. As written now ${fsid_to_dev} expands to > > > > fsid_to_dev='-e '\''s/st_fsid/Dev/'\''' resulting in: "sed: -e > > > > expression > > > > #4, char 1: unknown command: `''". Unfortunately, I have not yet been > > > > able > > > > to modify the expansion omitting the single qoutes around the shell > > > > variable. > > > > > > I'm sorry, I don't want to use "sed -i". That loses the original file > > > and makes it harder to reconstruct what has happened. > > > > What to do then? > > > > > > The second patch, src_libgo_go_syscall_wait.c.diff, is needed since > > > > WCONTINUED is not defined and is needed for WIFCONTINUED to be defined > > > > in > > > > wait.h. > > > > > > I don't understand that. <sys/wait.h> is a system header file. Are > > > you saying that it is impossible to use <sys/wait.h> and WIFCONTINUED > > > unless your source code does a #define WCONTINUED before #include'ing > > > <sys/wait.h>? That seems like a bug in the Hurd library code. > > > > The problem is that WCONTINUED is not defined in /usr/include/i386- > > gnu/bits/waitflags.h on Hurd. Only WNOHANG and WUNTRACED are. That causes > > WIFCONTINUED not to be defined in /usr/include/i386-gnu/bits/waitstatus.h. > > As > > WCONTINUED is not defined, I assume that WIFCONTINUED is not supported. > > > > From waitpid(2): > > WCONTINUED (since Linux 2.6.10) > > also return if a stopped child has been resumed by delivery of SIGCONT. > > > > @Samuel: more info? > > > > I think that that call to WIFCONTINUED in libgo/go/syscall/wait.c > > _Bool > > Continued (uint32_t *w) > > { > > return WIFCONTINUED (*w) != 0; > > } > > > > has to be omitted somehow for Hurd. > > It sound like the right fix is to use #ifdef WIFCONTINUED in > syscall/wait.c. If WIFCONTINUED is not defined, the Continued > function should always return 0.
I've got some ideas on how to solve the mksysinfo.sh problem. I just don't have time to try it out now. The idea is: fsid_to_dev='s/st_dev/Dev/' if grep 'define st_dev st_fsid' gen-sysinfo.go > /dev/null 2>&1; then fsid_to_dev='s/st_fsid/Dev/' ... remove: -e 's/st_dev/Dev/' \ add: -e ${fsid_to_dev} \ I can also easily submit a patch for WIFCONTINUED returning 0. Problem is I'll be AFK for the next week. Maybe this can wait, or you find a solution? Regardinga comm opttion for ps Samuel is the best source. Thanks!