On Mon, 11 Mar 2019 at 12:34, Richard Biener <rguent...@suse.de> wrote:
>
> On Mon, 11 Mar 2019, Andre Vieira (lists) wrote:
>
> > Hi,
> >
> > Any objections to me backporting this to GCC 8 and 7?
>
> No, go ahead (after proper testing).
>
Hi,
I've noticed that this new test fails on arm-none-linux-gnueabi
--with-mode thumb
--with-cpu cortex-a9
--with-fpu default
and with Dejagnu flags: -march=armv5t
(because the test forces float-abi=hard on a target that generates
thumb-1 by default, which isn't supported.
The attached patch fixes this by adding arm_fp16_ok effective target.
OK?
Christophe
> Richard.
>
> > Cheers,
> > Andre
> >
> > On 08/03/2019 17:30, Andre Vieira (lists) wrote:
> > > Hi,
> > >
> > > vcvtb.f16.f64 and vcvtb.f64.f16 were being made available even for FPUs
> > > that
> > > do not support double precision. This patch fixes that.
> > >
> > > Regression tested for arm-none-eabi.
> > >
> > > Committed in r269499.
> > >
> > > Cheers,
> > > Andre
> > >
> > > gcc/ChangeLog:
> > > 2019-03-08 Andre Vieira <andre.simoesdiasvie...@arm.com>
> > >
> > > * config/arm/arm.h (TARGET_FP16_TO_DOUBLE): Add TARGET_VFP_DOUBLE
> > > requirement.
> > >
> > > gcc/testsuite/ChangeLog:
> > >
> > > 2019-03-08 Andre Vieira <andre.simoesdiasvie...@arm.com>
> > >
> > > * gcc.target/arm/f16_f64_conv_no_dp.c: New test.
> >
>
> --
> Richard Biener <rguent...@suse.de>
> SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Graham Norton, HRB
> 21284 (AG Nuernberg)
2019-03-11 Christophe Lyon <christophe.l...@linaro.org>
* gcc.target/arm/f16_f64_conv_no_dp.c: Add arm_fp16_ok effective
target.
diff --git a/gcc/testsuite/gcc.target/arm/f16_f64_conv_no_dp.c
b/gcc/testsuite/gcc.target/arm/f16_f64_conv_no_dp.c
index 99b62a8..2620e57 100644
--- a/gcc/testsuite/gcc.target/arm/f16_f64_conv_no_dp.c
+++ b/gcc/testsuite/gcc.target/arm/f16_f64_conv_no_dp.c
@@ -1,4 +1,5 @@
/* { dg-do compile } */
+/* { dg-require-effective-target arm_fp16_ok } */
/* { dg-skip-if "do not override fpu" { *-*-* } { "-mfpu=*" } {
"-mfpu=fpv5-sp-d16" } } */
/* { dg-skip-if "do not disable fpu" { *-*-* } { "-mfloat-abi=soft" } { * } }
*/
/* { dg-skip-if "do not override fp16-format" { *-*-* } { "-mfp16-format=*" }
{ "-mfp16-format=ieee" } } */
