On 29/03/2019 11:01, Andrea Corallo wrote: > Hi all, > simple patch addressing minor style issue into > gcc/config/aarch64/cortex-a57-fma-steering.c. > > make BOOT_CFLAGS='-mcpu=cortex-a57' bootstrap > > Okay for trunk? > > Bests > Andrea > > > 2019-03-29 Andrea Corallo <andrea.cora...@arm.com> > > PR target/83033 > * config/aarch64/cortex-a57-fma-steering.c > (fma_forest): Fix missing copy constructor. > (fma_root_node): Likewise. > (func_fma_steering): Likewise. >
These should be commented, even if it's as simple as "Prohibit copy construction." R. > > 83033.patch > > diff --git a/gcc/config/aarch64/cortex-a57-fma-steering.c > b/gcc/config/aarch64/cortex-a57-fma-steering.c > index f2da03a..a390a62 100644 > --- a/gcc/config/aarch64/cortex-a57-fma-steering.c > +++ b/gcc/config/aarch64/cortex-a57-fma-steering.c > @@ -114,6 +114,8 @@ public: > void dispatch (); > > private: > + fma_forest (const fma_forest &); > + > /* The list of roots that form this forest. */ > std::list<fma_root_node *> *m_roots; > > @@ -180,6 +182,8 @@ public: > void dump_info (fma_forest *); > > private: > + fma_root_node (const fma_root_node &); > + > /* The forest this node belonged to when it was created. */ > fma_forest *m_forest; > }; > @@ -203,6 +207,7 @@ public: > void execute_fma_steering (); > > private: > + func_fma_steering (const func_fma_steering &); > void dfs (void (*) (fma_forest *), void (*) (fma_forest *, fma_root_node > *), > void (*) (fma_forest *, fma_node *), bool); > void analyze (); >
