在 2019/4/30 上午5:57, Jeff Law 写道:
On 3/1/19 1:39 AM, JunMa wrote:Hi Since MAX_INLINE_INSNS_AUTO should be below or equal to MAX_INLINE_INSNS_SINGLE (see params.def), there is no need to do second inlining limit check on growth when function not declared inline, this patch removes it. Bootstrapped and tested on x86_64-unknown-linux-gnu, is it ok for trunk?Regards Jun 2019-03-01 Jun Ma <ju...@linux.alibaba.com> *ipa-inline.c(want_inline_small_function_p): Remove redundant growth check when function not declared inlineSo I don't think anything in the option processing ensures MAX_INLINE_INSNS_AUTO is <= MAX_INLINE_INSNS_SINGLE. Furthermore, it doesn't look like the restriction is documented in any user documentation. Thus I'm not particularly comfortable removing this additional test. Jeff
The description at gcc onlinedocs says MAX_INLINE_INSNS_AUTO is more restrictive compare to limit applies to functions declared inline which is MAX_INLINE_INSNS_SINGLE. Thus, I think it is the user's responsibility to keep this restriction. Regards JunMa
