On Wed, May 15, 2019 at 8:29 PM Iain Sandoe <i...@sandoe.co.uk> wrote:
>
>
> > On 15 May 2019, at 19:02, Uros Bizjak <ubiz...@gmail.com> wrote:
> >
> > On Wed, May 15, 2019 at 6:48 PM Iain Sandoe <i...@sandoe.co.uk> wrote:
> >>
> >> Hi,
> >>
> >> There is at least one assembler that supports ‘setssbsy' but not “endbr*”.
> >> We can catch this by adding "-fcf-protection” to the
> >> check_effective_target_cet test.
> >
> > How about adding asm ("endbr") to the source?
>
> it would have to be ‘endbr32’ or ‘endbr64’ I suppose.. I guess
>
> #if __LP64__
> asm (“endbr64”);
> #else
> asm (“endbr32”):
> #endif
>
> would work?
>
> AFAICT that’s effectively what adding -fcf-protection does.
>
> I’m happy with either.
No need to complicate things too much, your original patch is OK.
Thanks,
Uros.
> Iain
>
>
