On 20/05/19 17:10 +0100, Jonathan Wakely wrote:
On 20/05/19 16:05 +0000, Szabolcs Nagy wrote:
On 20/05/2019 15:38, Jonathan Wakely wrote:
On 20/05/19 14:11 +0000, Szabolcs Nagy wrote:
On 17/05/2019 15:15, Jonathan Wakely wrote:
    * include/bits/random.h (seed_seq::param): Fix non-reserved name.
    * include/experimental/type_traits (is_detected_exact)
    (is_detected_exact_v): Likewise.
    * include/pstl/execution_defs.h (is_execution_policy)
    (is_execution_policy_v, __enable_if_execution_policy): Likewise.
    * include/pstl/execution_impl.h (__policy_traits): Likewise.
    * testsuite/17_intro/names.cc: Check for more non-reserved names.
    * testsuite/experimental/names.cc: New test.

on baremetal (newlib) targets i see

FAIL: experimental/names.cc (test for excess errors)

because

.../gcc/libstdc++-v3/testsuite/experimental/names.cc:25: fatal error: 
experimental/filesystem: No such file or directory

Here's what I've committed ...

thanks, the fatal error is now fixed.

so now i get a lot of other errors.
is this supposed to work on baremetal?

It should work just as well as testsuite/experimental/net/headers.cc
does, but that probably fails for bare metal too.

I think for now I should probably remove the Networking TS headers
from that file, or only include them for GNU/Linux.

This should fix it. Committed to trunk.


commit 45fe1693f8607a2ed089a304da559f513d9a1ded
Author: Jonathan Wakely <jwak...@redhat.com>
Date:   Mon May 20 21:16:34 2019 +0100

    Fix test failure due to Networking TS headers using mutexes
    
    Only include the Networking headers for targets with Gthreads, so that
    the uses of std::mutex and std::condition_variable don't cause errors.
    
            * testsuite/experimental/names.cc: Only include Networking TS headers
            on targets with the necessary Gthreads support.

diff --git a/libstdc++-v3/testsuite/experimental/names.cc b/libstdc++-v3/testsuite/experimental/names.cc
index 0746ca34e06..233b3487981 100644
--- a/libstdc++-v3/testsuite/experimental/names.cc
+++ b/libstdc++-v3/testsuite/experimental/names.cc
@@ -56,11 +56,13 @@
 #include <experimental/utility>
 #include <experimental/vector>
 // Networking
-#include <experimental/buffer>
-#include <experimental/internet>
-#include <experimental/io_context>
-#include <experimental/net>
-#include <experimental/netfwd>
-#include <experimental/socket>
-#include <experimental/timer>
-#include <experimental/executor>
+#ifdef _GLIBCXX_HAS_GTHREADS
+# include <experimental/buffer>
+# include <experimental/internet>
+# include <experimental/io_context>
+# include <experimental/net>
+# include <experimental/netfwd>
+# include <experimental/socket>
+# include <experimental/timer>
+# include <experimental/executor>
+#endif

Reply via email to