On 5/28/19, Martin Sebor <mse...@gmail.com> wrote: > On 5/28/19 4:24 AM, Martin Liška wrote: >> On 5/28/19 11:31 AM, David CARLIER wrote: >>> Hi, >>> >>> Here a tiny patch to fix few build warnings. >>> >>> Kind regards. >>> >> >> Hi. >> >> Well, I see a lot of these struct/class discrepancies when building GCC >> with LLVM. >> Question is whether it worth changing? > > I think it's nice for these to be spelled consistently and no benefit > to mixing and matching them. If it cleans up common warnings I see > no reason not to make the change. > > FWIW, it's also a common convention to use struct for PODs and class > for types with user-defined ctors, and even if GCC doesn't subscribe > to it, make a change in support of it is an improvement independent > of the Visual C++ warning. (As might be adding such a warning to > GCC to help enforce the convention on projects that do follow it.) > > Martin >
The bug for discussing -Wmismatched-tags is bug 61339, FWIW: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61339
