On Fri, 2019-05-31 at 11:52 +0000, Wilco Dijkstra wrote: > With -mcpu=generic the function alignment is currently 8, however almost all > supported cores prefer 16 or higher, so increase the default to 16:12. > This gives ~0.2% performance increase on SPECINT2017, while codesize is 0.12% > larger. > > ChangeLog: > 2019-05-31 Wilco Dijkstra <wdijk...@arm.com> > > * config/aarch64/aarch64.c (generic_tunings): Set function > alignment to 16. > > -- > > diff --git a/gcc/config/aarch64/aarch64.c > b/gcc/config/aarch64/aarch64.c > index > 0023cb37bbae5afe9387840c1bb6b43586d4fac2..ed1422af6aab5e3c6eeea37ec57 > e69b64092a0ab 100644 > --- a/gcc/config/aarch64/aarch64.c > +++ b/gcc/config/aarch64/aarch64.c > @@ -693,7 +693,7 @@ static const struct tune_params generic_tunings = > 4, /* memmov_cost */ > 2, /* issue_rate */ > (AARCH64_FUSE_AES_AESMC), /* fusible_ops */ > - "8", /* function_align. */ > + "16:12", /* function_align. */ > "4", /* jump_align. */ > "8", /* loop_align. */ > 2, /* int_reassoc_width. */
I have no objection to the change but could the commit message and/or comments be expanded to explain the ':12' part of this value. I couldn't find an explanation for it in the code and I don't understand what it does. Steve Ellcey sell...@marvell.com