On Tue, Jun 11, 2019 at 10:33:07AM -0400, Jason Merrill wrote: > On 6/11/19 9:59 AM, Matthew Beliveau wrote: > > Correct me if I'm wrong, but before the function checks for virtual > > bases, an if-statement checks for extra_warnings on line 6049(when my > > patch is applied). The check was there before I made my changes, and > > my test fails without -Wextra. Below is the code above the warning call: > > > > if (extra_warnings) > > for (vbases = CLASSTYPE_VBASECLASSES (t), i = 0; > > vec_safe_iterate (vbases, i, &binfo); i++) > > Ah, yes, thanks, I should have looked at the wider context. The patch is > OK.
Thanks! I checked in the patch. Marek
